Create Client config class for http client values #12369
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Browser subclasses for
RemoteConnection
andWebDriver
set deprecated value defaults toNone
Remote superclass for those throw the deprecation warning if they are not
None
so subclasses still need to send them.@isaulv told me to be careful creating objects in constructor parameters, so I'm just using
None
and setting defaults in first line.Also, I separated out the code for whether to use a proxy into a new private method
Motivation and Context
This is to match what Java is doing and better organize the constructor parameters
also sets us up to make more values configurable in a future PR.