Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Allows setting Remote webdriver ca_certs through REQUESTS_CA_BUNDLE env variable. #11957

Merged
merged 10 commits into from
Aug 14, 2023
Merged

[py] Allows setting Remote webdriver ca_certs through REQUESTS_CA_BUNDLE env variable. #11957

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7213454
Remote ca_certs can be set by REQUESTS_CA_BUNDLE env var.
miguelius Apr 27, 2023
7b5de8b
Describes the added behaviour.
miguelius Apr 27, 2023
46494e0
Merge branch 'trunk' into trunk
miguelius Apr 28, 2023
1a1b59e
Merge branch 'trunk' into trunk
miguelius May 3, 2023
08f432b
Merge branch 'trunk' into trunk
miguelius May 5, 2023
2e20d1a
Merge branch 'trunk' into trunk
miguelius May 9, 2023
cef15e3
Merge branch 'trunk' into trunk
miguelius Jun 28, 2023
b26a26b
Merge branch 'SeleniumHQ:trunk' into trunk
miguelius Jun 28, 2023
a986870
fixes issue with linter
miguelius Jun 29, 2023
dafa90f
Merge branch 'trunk' into trunk
miguelius Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions py/selenium/webdriver/remote/remote_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class RemoteConnection:

browser_name = None
_timeout = socket._GLOBAL_DEFAULT_TIMEOUT
_ca_certs = certifi.where()
_ca_certs = os.getenv("REQUESTS_CA_BUNDLE") if "REQUESTS_CA_BUNDLE" in os.environ else certifi.where()

@classmethod
def get_timeout(cls):
Expand Down Expand Up @@ -162,7 +162,8 @@ def reset_timeout(cls):
def get_certificate_bundle_path(cls):
"""
:Returns:
Paths of the .pem encoded certificate to verify connection to command executor
Paths of the .pem encoded certificate to verify connection to command executor. Defaults
to certifi.where() or REQUESTS_CA_BUNDLE env variable if set.
"""
return cls._ca_certs

Expand Down