Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptInsecureCerts capability is ignored #8261

Closed
ghostwords opened this issue Apr 30, 2020 · 6 comments
Closed

acceptInsecureCerts capability is ignored #8261

ghostwords opened this issue Apr 30, 2020 · 6 comments
Assignees
Labels

Comments

@ghostwords
Copy link

Setting acceptInsecureCerts to False is ignored by geckodriver. The same pattern works with ChromeDriver.

We need to disable acceptInsecureCerts in order to better simulate an actual person's experience browsing the Web. (People are unlikely to go past insecure cert warnings.)

In the following example, the unhandledPromptBehavior setting is respected, while acceptInsecureCerts remains set to True.

            caps = DesiredCapabilities.FIREFOX.copy()
            caps['acceptInsecureCerts'] = False;
            caps['unhandledPromptBehavior'] = "ignore";

            self.driver = webdriver.Firefox(firefox_profile=profile,
                                            firefox_binary=self.firefox_path,
                                            options=opts,
                                            desired_capabilities=caps,
                                            service_log_path=os.path.devnull)

(The above code is from badger-sett/crawler.py)

I originally filed this as mozilla/geckodriver#1718.

System

  • Version: 0.26.0
  • Platform: Ubuntu Linux 16.04
  • Firefox: 75
  • Selenium: Python bindings version 3.141.0
@ghost
Copy link

ghost commented Apr 30, 2020

👋 Hi there! Thank you for creating this issue.

I am the Selenium Assistant Bot 🤖, I triage issues in this repository. If I can't do it, I label it to help maintainers identify issues that need triaging.

I am an Open Source project 🙌, post bugs or ideas here!

@ghost
Copy link

ghost commented Apr 30, 2020

❗️ It seems this issue is not using any of the supported templates

💡 Supported issue types are (they start with):

  • 🐛 Bug Report (bugs found in a recent release)
  • 🚀 Feature Proposal (a useful feature you would like to propose)
  • 💥 Regression Report (a supported feature is not working anymore)

Issue templates help this project to stay in shape, please use them and fill them out completely. By doing that you are helping the project because the community and maintainers can provide prompt feedback, and potentially solve the issue.

If you are asking a question, a better way to address this is:

If you think this is incorrect, please feel free to open a new issue.

Thank you for your contributions.

@ghost ghost closed this as completed Apr 30, 2020
@ghostwords
Copy link
Author

"Thank you for your contributions."

@AutomatedTester
Copy link
Member

In future please don't delete the template and just follow the questions in the bug.

@AutomatedTester AutomatedTester self-assigned this May 1, 2020
ghostwords referenced this issue in EFForg/badger-sett May 13, 2020
Looks like d3666ae took care of the increased error rate.

Declining to visit broken SSL sites seems closer to human browsing.
@AutomatedTester
Copy link
Member

looking into this, Firefox is doing the right thing.

If you start using the *Options classes, which is the preferred way, this would have worked. Will rework the code that if it sees this to call the options instead.

ghostwords added a commit to EFForg/badger-sett that referenced this issue May 19, 2020
@ghostwords
Copy link
Author

ghostwords commented May 19, 2020

Thank you for looking into this, and for suggesting to stop using DesiredCapabilities.

Since DesiredCapabilities is deprecated, should users of up-to-date bindings see deprecation warnings?

titusfortner pushed a commit to titusfortner/selenium that referenced this issue Aug 13, 2020
…mHQ#8261

Firefox is incredibly strict here so we need to make sure that we
copy it across. When we can delete
capabilities this can be removed.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants