-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make reth data pipeline privacy aware #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o include is_private flag
* patch correct versions of seismic-reth * patch correct versions, builds * comment out alloy-core
Added is_private flags to storage value
sfyll
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100 push ups
ameya-deshmukh
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Added leaf node privacy flag. Default to false * default * add default keyword * working branch node with privacy flag * made changes for storageSlot; TODO: need to change EVM * changed how hasing storage is done * baseline point for working reth. need to work on channeling changes to include is_private flag * passed test * latest * latest * working revm-inspctors * debugging * debugging * debugging * debugging * build completed * test compiled * removing comment * rm comment * Use seismic's versions of alloy & revm dependencies (#2) * patch correct versions of seismic-reth * patch correct versions, builds * comment out alloy-core * test compiled * addressed comments * get rid of warnings * fix warnings * make test succeed * correct cargo.toml * restores cargo.toml * restores cargo.toml * added tests * fix fomrat --------- Co-authored-by: SFYLL <sd@seismic.systems> Co-authored-by: Christian Drappi <c@seismic.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall changes:
the value type was U256 before but it is FlaggedStorage, per changes from seismic-revm SeismicSystems/seismic-revm#9. Revm inspectors needed to run this
SeismicSystems/seismic-revm-inspectors#1
Testing:
run
make test
. 2 lock-file-test will fail per paradigmxyz/reth#9381Modified seismic-reth/crates/storage/provider/src/writer/mod.rs:731 to check if is_private flag is committed to database from evm execution outcome
Modified seismic-reth/crates/trie/trie/src/state.rs:347 to check if is_private flag is propagated from hashedStorages to postHashedStorages
Diff doc:
seismic-reth/crates/stages/stages/src/stages/hashing_storage.rs:106