Attester #6
Merged
Attester #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ME to explain why to avoid work duplication
… an OS permissions error with cargo test
…l run with the Sample Tee Type
…t_attestation_eval_evidence_handler_valid_request
cdrappi
reviewed
Oct 21, 2024
src/coco_as/handlers.rs
Outdated
| return Ok(Response::builder() | ||
| .status(StatusCode::BAD_REQUEST) | ||
| .body(Body::from(error_response)) | ||
| .unwrap()); |
There was a problem hiding this comment.
smells like we should have a function that takes in a string and returns this response object (DRY)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives routes for requesting a TEE attestation and verifying the attestation evidence. The PR also provides structs for making these requests and tests with example requests that work successfully.