Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate entity files with PostgreSQL's schema name #422

Merged
merged 9 commits into from
Jul 11, 2022
Merged

Generate entity files with PostgreSQL's schema name #422

merged 9 commits into from
Jul 11, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 self-assigned this Jan 5, 2022
@billy1624 billy1624 marked this pull request as ready for review January 5, 2022 08:29
@billy1624 billy1624 requested a review from tyt2y3 January 5, 2022 14:44
@tyt2y3 tyt2y3 force-pushed the master branch 2 times, most recently from 7ce941b to 33a87d7 Compare February 6, 2022 06:39
@tyt2y3
Copy link
Member

tyt2y3 commented Feb 12, 2022 •
edited
Loading

under what condition will schema be generated? always? or only when it is not public?

@billy1624
Copy link
Member Author

under what condition will schema be generated? always? or only when it is not public?

Will always generate schema_name for PostgreSQL, even when it's public. And it won't generate schema_name for MySQL & SQLite.

@tyt2y3
Copy link
Member

tyt2y3 commented Mar 6, 2022

Will always generate schema_name for PostgreSQL, even when it's public. And it won't generate schema_name for MySQL & SQLite.

I think a better behaviour is only generate schema_name when it is not public

@billy1624 billy1624 force-pushed the codegen-schema-name branch from 38abcd3 to 4e88f3c Compare March 7, 2022 05:39
@billy1624
Copy link
Member Author

Will always generate schema_name for PostgreSQL, even when it's public. And it won't generate schema_name for MySQL & SQLite.

I think a better behaviour is only generate schema_name when it is not public

Updated. Check 7137aa2

@tyt2y3
Copy link
Member

tyt2y3 commented Mar 31, 2022

Sorry for the conflict, I would actually want to merge it now

@itsbalamurali
Copy link

@billy1624 @tyt2y3 any plans to merge this sooner?

@tyt2y3
Copy link
Member

tyt2y3 commented Jun 23, 2022

Conflict. Sad :(

@billy1624
Copy link
Member Author

Hey @tyt2y3, conflict resolved :)

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 10, 2022

Sad. Conflict again with WriterContext

@billy1624
Copy link
Member Author

Conflict once again resolved

@tyt2y3 tyt2y3 merged commit c5aa63e into master Jul 11, 2022
@tyt2y3 tyt2y3 deleted the codegen-schema-name branch July 11, 2022 15:11
@tyt2y3
Copy link
Member

tyt2y3 commented Jul 11, 2022

Finally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema name is missing in the generated Model entity (Postgresql)
3 participants
@billy1624 @tyt2y3 @itsbalamurali