Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve connect timeout in schema discovery #2461

Merged

Conversation

ctaque
Copy link
Contributor

@ctaque ctaque commented Dec 24, 2024

PR Info

This PR resolves the timeout in schema discovery in larger databases when generating entities with sea-orm-cli

Bug Fixes

  • This PR increases the acquire timeout of the connection of the schema discovery in Postgresql from 30s to 240s.

The discovery of my database now work with this value. IMO it could be parametrized in the cli.

Breaking Changes

Changes

  • The connection is now an sqlx pool with an acquire_timeout of 240s

@tyt2y3
Copy link
Member

tyt2y3 commented Dec 26, 2024

thanks, I agree with that it could be parametrized in the cli.
would you be able to work on it?

acquire timeout parameter of the connection in seconds
@ctaque
Copy link
Contributor Author

ctaque commented Dec 26, 2024

I added this commit 006fc1e to add the option to the cli and use it in Mysql, Postgresql and Sqlite

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tyt2y3 tyt2y3 merged commit 432f1f6 into SeaQL:master Feb 19, 2025
Copy link

🎉 Released In 1.1.6 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to generate entities for large schema
2 participants