Introduce ARITY to PrimaryKeyTrait #2180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@billy1624 can you help looking at the test failures? |
tyt2y3
commented
Mar 29, 2024
| @@ -116,7 +116,7 @@ where | |||
| { | |||
| // so that self is dropped before entering await | |||
| let mut query = self.query; | |||
| if db.support_returning() && <A::Entity as EntityTrait>::PrimaryKey::iter().count() > 0 { | |||
There was a problem hiding this comment.
I believe all our primary keys has len > 0, so this check is redundant? @billy1624
Merged
|
Closed in favour of #2185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the last breaking changes I want to ship in 1.0