h265 add docs and tests #371
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying scuffle-docrs with
|
| Latest commit: |
e22a17e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4d079428.scuffle-docrs.pages.dev |
| Branch Preview URL: | https://pr-371.scuffle-docrs.pages.dev |
TroyKomodo
reviewed
Feb 21, 2025
| /// 2 means the stream supports tile based parallel decoding. | ||
| /// | ||
| /// 3 means the stream supports entropy coding sync based parallel decoding. | ||
| pub parallelism_type: u8, |
There was a problem hiding this comment.
Perhaps we should create a nutype-enum for this field which has the fields u are talking about but also supports unknowns.
| /// | ||
| /// 3 means the stream supports entropy coding sync based parallel decoding. | ||
| pub parallelism_type: u8, | ||
| /// The `avg_frame_rate` as a u16. |
There was a problem hiding this comment.
how does this field work for non-integer framerates
| /// | ||
| /// 1 means the stream has a constant framerate. | ||
| /// | ||
| /// 2 means the representation of each temporal layer in the stream has a constant framerate. |
There was a problem hiding this comment.
Likewise with the nutype-enum
| pub nalus: Vec<Bytes>, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, PartialEq, Copy)] | ||
| /// Nalu Type | ||
| /// The Nalu Type. |
There was a problem hiding this comment.
This should be a nutype enum
| pub constant_frame_rate: u8, | ||
| /// The `num_temporal_layers` as a u8. This is the count of tepmoral layers or `sub-layer`s as defined in ISO/IEC 23008-2. |
philipch07
force-pushed
the
pch07/h265-add-docs-and-tests
branch
2 times, most recently
from
a7127b6 to
2bab62b
Compare
philipch07
force-pushed
the
pch07/h265-add-docs-and-tests
branch
from
2bab62b to
262b697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docs and updates tests to h265.
CLOUD-30