Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pillow #38

Closed
wants to merge 1 commit into from
Closed

Unpin pillow #38

wants to merge 1 commit into from

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Nov 1, 2020

This PR adds the relevant images after unpinning pillow.

@pp-mo
Copy link
Member

pp-mo commented Nov 9, 2020

This is not the right way, I think.
The 18-ish new files are all duplicates of the old ones with different names (as the hashes have changed).
But that means that the old files no longer have names which match their hashes, which breaks the logic
-- which is what the test is for + why it fails.

I think you must rename them, not duplicate.
But it means changing Iris too : we need the SHAs to change in Iris imagerepo.json, at the same time as unpinning pillow in Iris travis, and updating its reference commit for test-iris-imagehash download. They all have to happen at once.

@pp-mo
Copy link
Member

pp-mo commented Nov 9, 2020

Also... there are a lot more than 19 failures.
This is not a trivial exercise, or we would have done it instead of pinning #30
😟

@bjlittle bjlittle closed this Apr 8, 2021
@bjlittle
Copy link
Member Author

bjlittle commented Apr 8, 2021

@pp-mo this was a work in progress... and just need further analysis

i've jumped though these hoops before... i'll restart this pr from afresh, thanks

@bjlittle bjlittle deleted the unpin-pillow branch September 21, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants