Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FB] default_units: Update merge-base to commit 1873ce14 #3792

Merged

Conversation

abooton
Copy link
Contributor

@abooton abooton commented Aug 19, 2020

Update default units feature branch to base commit 1873ce1 (current head of master)

@abooton
Copy link
Contributor Author

abooton commented Aug 19, 2020

The default_units feature branch merges into upstream/master without conflict when merged via the commandline:

git checkout upstream/master -b  default_units_base1873ce14
git merge --no-ff upstream/default_units

However, when trying to merge by creating a PR via GitHub, GitHub indicates a conflict in the file: docs/iris/example_code/Meteorology/lagged_ensemble.py
which no longer exists in upstream/master.

As such, the conflict can not be resolved simply because there aren't any conflicts!

Therefore, I have created a new feature branch, upstream/default_units2, branching at merge-base 1873ce14. I then merged in the original feature branch (as outlined above). I confirmed that the docs/iris/example_code/Meteorology/lagged_ensemble.py does not exist (as in master).

When merged in default_units2, this should replace default_units, which will then merge into upstream/master correctly.
This will preserve the original commit-ids that were actually reviewed (rather than rebasing that alters the commits) and GitHub will preserve the issue links and commit information.

@abooton abooton changed the title Update Default units feature branch base1873ce14 Update default_units feature branch base1873ce14 Aug 19, 2020
@trexfeathers
Copy link
Contributor

Good luck @abooton !

@trexfeathers trexfeathers merged commit e99f960 into SciTools:default_units2 Aug 19, 2020
@abooton abooton changed the title Update default_units feature branch base1873ce14 [FB] default_units: Update merge-base to commit 1873ce14 Aug 19, 2020
@abooton abooton deleted the default_units_base1873ce14 branch August 20, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants