Remove tests/grib_save_rules.py which has been moved to iris-grib #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could not review pull request. It may be too large, or contain no reviewable changes. |
This was referenced Feb 20, 2020
lbdreyer
commented
Feb 20, 2020
| grib_save_rules.set_discipline_and_parameter(cube, grib) | ||
| mock_set.assert_any_call(grib, "discipline", 255) | ||
| mock_set.assert_any_call(grib, "parameterCategory", 255) | ||
| mock_set.assert_any_call(grib, "parameterNumber", 255) |
There was a problem hiding this comment.
This was just removed (not moved to iris-grib)
We already have a test for this: https://github.com/SciTools/iris-grib/blob/master/iris_grib/tests/unit/save_rules/test_set_discipline_and_parameter.py#L45
lbdreyer
commented
Feb 20, 2020
| grib_save_rules.set_discipline_and_parameter(cube, grib) | ||
| mock_set.assert_any_call(grib, "discipline", 10) | ||
| mock_set.assert_any_call(grib, "parameterCategory", 3) | ||
| mock_set.assert_any_call(grib, "parameterNumber", 0) |
There was a problem hiding this comment.
This was just removed (not moved to iris-grib)
We already have a test for this: https://github.com/SciTools/iris-grib/blob/master/iris_grib/tests/unit/save_rules/test_set_discipline_and_parameter.py#L50
lbdreyer
commented
Feb 20, 2020
| grib_save_rules.set_discipline_and_parameter(cube, grib) | ||
| mock_set.assert_any_call(grib, "discipline", 0) | ||
| mock_set.assert_any_call(grib, "parameterCategory", 1) | ||
| mock_set.assert_any_call(grib, "parameterNumber", 22) |
There was a problem hiding this comment.
This test was added but rejigged slightly to match the style of the other tests in /iris_grib/tests/unit/save_rules/test_set_discipline_and_parameter.py
MoseleyS
added a commit
to MoseleyS/iris
that referenced
this pull request
Mar 6, 2020
* master: Remove TestGribMessage (SciTools#3672) Removed iris.tests.integration.test_grib_load and related CML files. (SciTools#3670) Removed grib-specific test to iris-grib. (SciTools#3671) Fixed asv project name to 'scitools-iris'. (SciTools#3660) Remove cube iter (SciTools#3656) Remove test_grib_save.py (SciTools#3669) Remove test_grib2 integration tests (SciTools#3664) Remove uri callback test which is moved to iris-grib (SciTools#3665) 2v4 mergeback picks (SciTools#3668) Remove test_grib_save_rules.py which has been moved to iris-grib (SciTools#3666) Removed ununused skipIf. (SciTools#3632) Remove grib-specific test. (SciTools#3663) Remove obsolete test. (SciTools#3662) remove redundant tests (SciTools#3650) Fixed tests since Numpy 1.18 deprecation of non-int num arguments for linspace. (SciTools#3655)
trexfeathers
added a commit
that referenced
this pull request
Mar 18, 2020
* Fixed tests since Numpy 1.18 deprecation of non-int num arguments for linspace. (#3655) * remove redundant tests (#3650) * Remove obsolete test. (#3662) * Remove grib-specific test. (#3663) * Removed ununused skipIf. (#3632) * Remove test_grib_save_rules.py which has been moved to iris-grib (#3666) * 2v4 mergeback picks (#3668) * Stop PPDataProxy accessing the file when no data is needed. (#3659) * Add 2.4 whatsnew into full whatsnew list. Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Remove uri callback test which is moved to iris-grib (#3665) * Remove test_grib2 integration tests (#3664) * Remove test_grib_save.py (#3669) * Remove cube iter (#3656) * Fixed asv project name to 'scitools-iris'. (#3660) * Removed grib-specific test to iris-grib. (#3671) * Removed iris.tests.integration.test_grib_load and related CML files. (#3670) * Remove TestGribMessage (#3672) * Switched use of datetime.weekday() to datetime.dayofwk. (#3687) * New image hashes for mpl 3x2 (#3682) * New image hash for iris.test.test_plot.TestSymbols.test_cloud_cover with matplotlib 3.2.0. * Further images changes for mpl3x2. * Yet more updated image results. * Correct and improve dev-guide section on fixing graphics-tests. (#3683) * Correct and improve dev-guide section on fixing graphics-tests. * Review changes + general rethink. * Reduce duplication between 'graphics-tests' and general 'tests' page. * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> Co-authored-by: Bill Little <bill.james.little@gmail.com> Co-authored-by: lbdreyer <lbdreyer@users.noreply.github.com> Co-authored-by: Jon Seddon <17068361+jonseddon@users.noreply.github.com>
stephenworsley
added a commit
to stephenworsley/iris
that referenced
this pull request
Jun 8, 2020
… default_units_patch * 'default_units' of https://github.com/SciTools/iris: Unify saving behaviour of "unknown" and "no_unit" (SciTools#3711) Change default loading unit from "1" to "unknown" (correct branch) (SciTools#3709) Change default units to "unknown" for all DimensionalMetadata (SciTools#3713) Update docs CubeList.extract method (SciTools#3694) Correct and improve dev-guide section on fixing graphics-tests. (SciTools#3683) New image hashes for mpl 3x2 (SciTools#3682) Switched use of datetime.weekday() to datetime.dayofwk. (SciTools#3687) Remove TestGribMessage (SciTools#3672) Removed iris.tests.integration.test_grib_load and related CML files. (SciTools#3670) Removed grib-specific test to iris-grib. (SciTools#3671) Fixed asv project name to 'scitools-iris'. (SciTools#3660) Remove cube iter (SciTools#3656) Remove test_grib_save.py (SciTools#3669) Remove test_grib2 integration tests (SciTools#3664) Remove uri callback test which is moved to iris-grib (SciTools#3665) 2v4 mergeback picks (SciTools#3668) Remove test_grib_save_rules.py which has been moved to iris-grib (SciTools#3666) Removed ununused skipIf. (SciTools#3632) Remove grib-specific test. (SciTools#3663) Remove obsolete test. (SciTools#3662)
tkknight
pushed a commit
to tkknight/iris
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to: SciTools/iris-grib#195