Fix for eccodes>=2.32.1 and python-eccodes>=1.6.1 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
commented
Nov 15, 2023
bjlittle
commented
Nov 15, 2023
bjlittle
commented
Nov 15, 2023
bjlittle
commented
Nov 15, 2023
bjlittle
commented
Nov 15, 2023
pp-mo
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Thanks for taking this on @bjlittle.
No problem with this approach, basically.
-- IMHO the solution only looks untidy because the problem space is such a mess.
I pushed have back on some details + suggestions
-- please see what you think
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
|
@pp-mo Back to you fella 👍 |
|
@pp-mo Awesome, thanks! 🍻 |
bjlittle
added a commit
that referenced
this pull request
Nov 16, 2023
* Updated environment lockfiles * Fix for eccodes>=2.32.1 and python-eccodes>=1.6.1 (#361) * Fix for eccodes>=2.32.1 and python-eccodes>=1.6.1 * Update iris_grib/message.py Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk> --------- Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk> --------- Co-authored-by: Lockfile bot <noreply@github.com> Co-authored-by: Bill Little <bill.little@metoffice.gov.uk> Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request updates
iris-gribto cater within changes in the latest version ofeccodes.Due to this change in
eccodesbehaviour, I've defensively introduces a minimum pin for botheccodesandpython-eccodes.Note that, this PR is targeting the
auto-update-lockfilesbranch, which is the base branch of pull-request #354.