Correct rounding of vertical coordinates. #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks sensible to me, more safe than just using int! I assigned myself yesterday as I wasn't sure anyone was looking at this, but it sounds like @alastair-gemmell may be? If so I'll hold off on merging. |
alastair-gemmell
requested review from
alastair-gemmell
and removed request for
alastair-gemmell
alastair-gemmell
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO we should be rounding any time we convert a float value to a scaled integer.
See: #211
However, it looks like that is awkward and will get in the way of the 0.16 release, so I think it's not worth it now.