Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds codec interface + registry and migrate existing code #154

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Oct 21, 2024

This pull request includes various updates primarily focused on enhancing the configuration, updating Python version support, and refactoring the codebase for better modularity and maintainability. The most important changes include updating Python versions in the CI workflows, adding a new codec interface, and refactoring the CDF handling code.
It also drops support for AMDA CSV format.

Configuration Updates:

  • .editorconfig: Added max_line_length = 120 to enforce a maximum line length.

CI Workflow Updates:

Code Refactoring:

Minor Code Changes:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@jeandet jeandet added enhancement New feature or request WIP Work In Progress (don't merge) labels Oct 21, 2024
@jeandet jeandet added this to the 1.5 milestone Oct 21, 2024
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
…rs is a pain

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@jeandet jeandet marked this pull request as ready for review October 23, 2024 15:46
@jeandet jeandet requested a review from brenard-irap October 23, 2024 15:47
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Copy link

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 71.76471% with 24 lines in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (771819c) to head (40dfac9).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
speasy/core/codecs/codecs_registry.py 66.66% 8 Missing and 5 partials ⚠️
speasy/core/codecs/codec_interface.py 70.00% 6 Missing ⚠️
...ct_archive_downloader/direct_archive_downloader.py 50.00% 1 Missing and 1 partial ⚠️
speasy/webservices/amda/_impl.py 83.33% 1 Missing ⚠️
speasy/webservices/amda/ws.py 50.00% 1 Missing ⚠️
speasy/webservices/csa/__init__.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   86.61%   86.56%   -0.05%     
==========================================
  Files          54       57       +3     
  Lines        3548     3499      -49     
  Branches      578      548      -30     
==========================================
- Hits         3073     3029      -44     
+ Misses        308      303       -5     
  Partials      167      167              
Flag Coverage Δ
unittests 85.79% <71.76%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeandet jeandet removed the WIP Work In Progress (don't merge) label Oct 24, 2024
@jeandet jeandet merged commit 02629e2 into SciQLop:main Oct 24, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants