-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add describe-env-dependencies command #207
Conversation
Wow, not even 12 hours after I posted my issue! I'll want to play around with this on a few existing environments that I have on top of a standard code review to get a better feel for how it works. Regarding your first bullet point, I think since describe has a relatively consistent meaning in Sceptre (and the aws cli in general), that desecribe-env-dependencies is not the best name. Off the top of my head, something like output-dependency-graph may be better, but I haven't yet convinced myself that it is the best name either. I'll look into how to get pictures into the docs, it seems doable in principle, but I don't know how to do it right now. Thanks for the PR! |
@cboss24 Thanks for PR. Could you give some specific use cases for this? I'm reluctant to merge as this seems to add a bit of complexity (API changes etc) for low benefit to Sceptre's core functionality. |
Two main uses cases I see:
I disagree that this is not core Sceptre functionality. One of Sceptre's killer features is the ability to automatically detect dependencies and orchestrate the stack commands around those dependencies. In my opinion this change is simply enhancing this core feature. Let me know what you think! |
@theseanything @b-t-g any thoughts on this PR? |
… the stack dependencies within an environment This commit also allows users to output their dependencies using the DOT language, which can be used to graph the dependencies using programs like Graphwiz.
ed42ceb
to
8090f5d
Compare
Sorry for the delay @cboss24. I agree it is an enhancement, but not fundamental to Sceptre functionality. For the sake of project maintainability - I feel this is something we are going to have to leave out. We are a looking at maybe introducing the ability to extend sceptre by adding custom cli commands/functionality as plugins which can be pip installable - this may be a good candidate for that. |
Fix #201 Add describe-env-dependencies to expose the stack dependencies within an environment
This commit also allows users to output their dependencies using the DOT language, which can be used to graph the dependencies using programs like Graphwiz.
Couple questions:
graph
be more user friendly?