Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template bucket encryption #491

Closed
craighurley opened this issue Oct 25, 2018 · 3 comments
Closed

template bucket encryption #491

craighurley opened this issue Oct 25, 2018 · 3 comments
Labels
type: feature request

Comments

@craighurley
Copy link
Contributor

craighurley commented Oct 25, 2018 •
edited
Loading 

$ sceptre --version
Sceptre, version 1.4.2

When using template_bucket_name (https://sceptre.cloudreach.com/latest/docs/environment_config.html#template_bucket_name), the bucket is automatically created by sceptre if it does not already exist:

If the bucket does not exist, Sceptre creates one using the given name, in the AWS region specified by region.

... it would be nice if server side encryption was enabled by default; got to keep ticking those encryption boxes to keep security folks happy :)
@ngfgrant
Copy link
Contributor

Hi @craighurley yeh I agree happy to look over a PR for this.

@craighurley craighurley mentioned this issue Jun 10, 2019
Closed
@ngfgrant
Copy link
Contributor

Closing as #730 gives a more broad template bucket config option including encryption.

@craighurley craighurley mentioned this issue Sep 30, 2021
Closed
@jfalkenstein jfalkenstein mentioned this issue Nov 7, 2021
Merged
9 tasks
jfalkenstein added a commit that referenced this issue Dec 27, 2021
@jfalkenstein
[Resolve #1114,#886,#491] Project Dependencies part 2: Resolvable rol…
d18cf70 
…e_arn and template_bucket_name (#1153)

This is the second in a series of pull requests that addresses #1114 , allowing Sceptre to manage its own dependencies.

## In this PR:
* The ResolvableValueProperty is created, creating a property that can resolve to a single value (not a list or dict)
* role_arn and template_bucket_name are now fully resolvable properties
    - role_arn also resolves the issue #886 
    - template_bucket_name also provides a solution to the issue #491 
* If template_bucket_name is set to None on a stack, it will be interpreted as if it wasn't there at all. _This will be important in future Pull Requests so that if template_bucket_name is inherited from the stack_group, it won't actually create a circular dependency on the stack that outputs that bucket name._
* Documentation is clarified on setting stack dependencies on a StackGroup to be shared across all stacks in that group as well as a warning about circular dependencies.
@jfalkenstein
Copy link
Contributor

jfalkenstein commented Dec 28, 2021 •
edited
Loading

The spirit of this ticket has been accomplished now that the template_bucket_name is resolvable, from #1153 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@craighurley @ngfgrant @jfalkenstein