fix: Composer prevails over env for Nginx and Composer too #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
previously approved these changes
Feb 16, 2024
| # No Composer | ||
| } | ||
|
|
||
| test::helpers::composer_deploy() { |
There was a problem hiding this comment.
suggestion(non-blocking): with both composer_deploy and classic_deploy sharing most of the code base, we could create a common function named test::helpers::deploy_common that is called by these functions.
There was a problem hiding this comment.
Right, applied in 4217951
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
…ldpack into tests/composer_prevails
EtienneM
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check that:
scalingo-20andscalingo-22).NGINX_VERSIONcomposer.jsoncomposer.jsonwill always prevail overNGINX_VERSIONif both are set.NGINX_VERSIONcomposer.jsoncomposer.jsonwill always prevail overNGINX_VERSIONif both are set.I had to make quite a few changes to be able to do that in a way that follows the testing logic we have.