Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline: Refactor cdc_wisqars to ingest new data #3953

Merged
merged 13 commits into from
Feb 7, 2025

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Feb 7, 2025

Description and Motivation

Adjusts cdc_wisqars data source to handle updated source data for gun homicides and gun suicides

  • renames by race source files to match loading pattern
  • uses existing WISQARS constants instead of strings
  • revert to remove loading of general "gun_deaths" for now; will re-implement in future PR
  • rename some variables for clarity
  • move renaming of values and column names to their HET versions earlier in the code flow when possible
  • handle loading of HISPANIC and UNKNOWN race rows from the ethnicity source data
  • switch over tests to read in the real source data

Has this been tested? How?

  • test source data and golden data updated and passing

Types of changes

(leave all that apply)

  • Refactor / chore

New frontend preview link is below in the Netlify comment 😎

@benhammondmusic benhammondmusic marked this pull request as ready for review February 7, 2025 04:57
Copy link
Collaborator

@eriwarr eriwarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@benhammondmusic benhammondmusic merged commit 52e46aa into SatcherInstitute:main Feb 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants