Migrate unknown map to d3 #3923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
added 3 commits
January 22, 2025 16:16
…r isMobile property
benhammondmusic
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
awesome work! I think once we've moved the final rate map over to d3, we can then pursue refactoring things to share functionality between all the cards. like there should probably be one unified tooltip style for all the cards, and the info inside each can change but the component can be shared. same for any legends, axis ticks, etc etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
This PR converts the unknowns choropleth map from Vega to D3.
Has this been tested? How?
Screenshots (if appropriate)
Types of changes
New frontend preview link is below in the Netlify comment 😎