Updated source DAG with fallback demo CDCVaccinationNational #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhammondmusic
requested changes
Jan 20, 2025
| @@ -29,6 +29,7 @@ | |||
|
|
|||
| cdc_vaccination_national_exporter_payload_race = { | |||
| "dataset_name": _CDC_VACCINATION_NATIONAL_DATASET_NAME, | |||
| "should_export_as_alls": True, | |||
There was a problem hiding this comment.
So we actually only want to extract the ALLs from one breakdown type, like sex OR age OR race. The way you have it here it would rewrite the same ALL rows 3 times
There was a problem hiding this comment.
Ah I see now. I didn't fully understand the issue as written. I'll fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
closes #3783
Has this been tested? How?
Yes. Using pytest against the file
Screenshots (if appropriate)
Types of changes
(leave all that apply)
New frontend preview link is below in the Netlify comment 😎