Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addresses bug with truncation and filtering #3896

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

kccrtv
Copy link
Collaborator

@kccrtv kccrtv commented Dec 30, 2024

Description and Motivation

  • truncates author names only on smaller screens (below the 'md' breakpoint).
  • stores the full author names and filters the value of the full author name, when previously it was using the label. this caused issues with finding the articles written by the Authors with truncated names
  • added isMdAndUp to the dependencies to update truncation logic on viewport changes.

Has this been tested? How?

tests passing

Screenshots (if appropriate)

Screenshot 2024-12-30 at 4 54 04 PM

Screenshot 2024-12-30 at 4 53 43 PM

Types of changes

  • Bug fix

New frontend preview link is below in the Netlify comment 😎

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7bfa0b7
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/677c0726723672000807eca2
😎 Deploy Preview https://deploy-preview-3896--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kccrtv kccrtv marked this pull request as ready for review December 30, 2024 23:03
Copy link
Collaborator

@benhammondmusic benhammondmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

useEffect(() => {
if (data?.data) {
const articles = data.data
setAllArticles(articles)

const authorSet = new Set<string>()
const authorMap = new Map<string, string>()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, using a real javascript Map in the wild!

@kccrtv kccrtv merged commit 2707143 into SatcherInstitute:main Jan 6, 2025
10 of 11 checks passed
@kccrtv kccrtv deleted the news-filters branch January 6, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants