Skip to content

Commit

Permalink
Use assumed-size arrays in CCPP, Fortran/metadata consistency fixes i…
Browse files Browse the repository at this point in the history
…n CCPP (NOAA-EMC#527)

- Update the submodule pointers for ccpp-physics and fv3atm and the regression test baseline date tag
- Small update of `tests/ci/repo_check.sh` from @MinsukJi-NOAA
- Move coupled tests in `rt.conf` to the top, because these take the longest to wait in the queue and to run; **BUT**: needed to move ATMW tests to end of `rt.conf`, since WW3 is not able to support parallel builds. By moving it to the end, we are as "lucky" as before in a sense that only ten builds can happen at the same time, and the two builds that involve WW3 are sufficiently far apart to not overlap - see issue ufs-community/ufs-weather-model#550
- Change location of temporary/personal baseline directories on Cheyenne from $WORK to $SCRATCH to avoid disk space limitations
- Increase walltime for compile jobs on wcoss_dell_p3 from 50min to 1hr

Co-authored-by: Dustin Swales <dustin.swales@noaa.gov>
  • Loading branch information
climbfuji and dustinswales authored Apr 30, 2021
1 parent 2fc0ce3 commit 4820bb8
Show file tree
Hide file tree
Showing 14 changed files with 12,104 additions and 12,314 deletions.
2 changes: 1 addition & 1 deletion FV3
210 changes: 105 additions & 105 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

4,384 changes: 2,192 additions & 2,192 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

4,213 changes: 2,053 additions & 2,160 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

214 changes: 107 additions & 107 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

4,788 changes: 2,394 additions & 2,394 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

532 changes: 266 additions & 266 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

4,851 changes: 2,372 additions & 2,479 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

456 changes: 228 additions & 228 deletions tests/RegressionTests_wcoss_cray.log

Large diffs are not rendered by default.

4,648 changes: 2,324 additions & 2,324 deletions tests/RegressionTests_wcoss_dell_p3.log

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions tests/ci/repo_check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ done
cd ${GITHUB_WORKSPACE}
git remote add upstream ${base[repo]}
git fetch -q upstream ${base[branch]}
common=$(git merge-base upstream/${base[branch]} @)
common=$(git merge-base ${base[sha]} @)
if [[ $common != ${base[sha]} ]]; then
comment="* ufs-weather-model **NOT** up to date\n"
fi
Expand All @@ -89,7 +89,7 @@ for submodule in $submodules; do
eval cd ${GITHUB_WORKSPACE}/'${'$submodule'[dir]}'
eval git remote add upstream '${'$submodule'[repo]}'
eval git fetch -q upstream '${'$submodule'[branch]}'
common=$(eval git merge-base upstream/'${'$submodule'[branch]}' @)
common=$(eval git merge-base '${'$submodule'[sha]}' @)
if (eval test $common != '${'$submodule'[sha]}'); then
comment+="* $submodule **NOT** up to date\n"
fi
Expand Down
2 changes: 1 addition & 1 deletion tests/fv3_conf/compile_bsub.IN_wcoss_dell_p3
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#BSUB -oo out
#BSUB -eo err
#BSUB -J @[JBNME]
#BSUB -W 00:50
#BSUB -W 01:00
#BSUB -q @[QUEUE]
#BSUB -P GFS-DEV
#BSUB -n 1
Expand Down
110 changes: 57 additions & 53 deletions tests/rt.conf

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions tests/rt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ elif [[ $MACHINE_ID = cheyenne.* ]]; then
PARTITION=
dprefix=/glade/scratch
DISKNM=/glade/p/ral/jntp/GMTB/ufs-weather-model/RT
STMP=/glade/work
STMP=$dprefix
PTMP=$dprefix
SCHEDULER=pbs
cp fv3_conf/fv3_qsub.IN_cheyenne fv3_conf/fv3_qsub.IN
Expand Down Expand Up @@ -413,7 +413,7 @@ if [[ $TESTS_FILE =~ '35d' ]]; then
TEST_35D=true
fi

BL_DATE=20210428
BL_DATE=20210430
if [[ $MACHINE_ID = hera.* ]] || [[ $MACHINE_ID = orion.* ]] || [[ $MACHINE_ID = cheyenne.* ]] || [[ $MACHINE_ID = gaea.* ]] || [[ $MACHINE_ID = jet.* ]]; then
RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-${BL_DATE}/${RT_COMPILER^^}}
else
Expand Down

0 comments on commit 4820bb8

Please sign in to comment.