Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve time codes hitbox and narrow window visibility #332

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

Samillion
Copy link
Owner

@Samillion Samillion commented Jan 21, 2025

Changes:

  • Improve time codes hitbox in different scenarios
  • Improve narrow window trigger

Known issues: [old issues, not caused by this PR]

  • Hitbox width will not be accurate if font size for time codes changes drastically
    • Introduce width offset for user to control as an option in the future? ie: 10 or -10
  • Using time_format=dynamic, with a video longer than one hour, once playback time reaches one hour or more, the hitbox doesn't get changed to match.
    • If you invoke milliseconds (right click) on/off, it is fixed
    • This hints that hitbox value isn't updated and needs a measure to request_init(), which is very expensive with playback time
    • I don't want to rush implementing a fix for this, so it will be added in a separate PR when a proper method is found

Applied fix for time codes width hitbox in dynamic time format: 01651f0
I'm certain there is a better method, but nothing comes to mind. This works and doesn't spam call request_init() needlessly.

@Samillion Samillion merged commit 23c3d5d into main Jan 21, 2025
@Samillion Samillion deleted the dev_timecodes_hitbox branch January 21, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant