fix: improve time codes hitbox and narrow window visibility #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Known issues: [old issues, not caused by this PR]
10
or-10
Usingtime_format=dynamic
, with a video longer than one hour, once playback time reaches one hour or more, the hitbox doesn't get changed to match.If you invoke milliseconds (right click) on/off, it is fixedThis hints that hitbox value isn't updated and needs a measure torequest_init()
, which is very expensive with playback timeI don't want to rush implementing a fix for this, so it will be added in a separate PR when a proper method is foundApplied fix for time codes width hitbox in dynamic time format: 01651f0
I'm certain there is a better method, but nothing comes to mind. This works and doesn't spam call
request_init()
needlessly.