New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve hovered chapter display if thumbfast is disabled #286

Merged

Samillion merged 2 commits into main from dev_chapter_tooltip_refactor

Dec 30, 2024

Owner

Samillion commented Dec 30, 2024

Fixes: #285

If show_title and show_chapter_title are disabled and thumbfast is not used, show hovered chapter title above the time code tooltip instead of appending it in the same time code line
Align a min and max value so that on hover on end/start, chapter title tooltip doesn't go out of bound

if show_title and thumbfast are disabled, but show_chapter_title is enabled, replace chapter_title with hovered chapter. Similar to how title is changed on chapter hover, if show_title is enabled and thumbfast is disabled.

Samillion added 2 commits

December 30, 2024 10:05


          refactor: show hovered chapter above timecode tooltip

3ff2603


          refactor: show hovered chapter in chapter_title if title is disabled

02d8e2b

Samillion merged commit 5cc01eb into main

Samillion deleted the dev_chapter_tooltip_refactor branch

December 30, 2024 15:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet