refactor: move slider seekranges & handle drawing into own functions #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce code duplication and complexity by separating slider seekrange & handle drawing from the rest of the slider. As a result seekrange drawing is now the same on both the normal and persistent seekbar which closes #173.
Changes
draw_slider_handle
function which takes an element its ass and draws a handle using settings provided byuser_opts
.draw_slider_seekranges
function which takes an element its ass and draws seekranges using settings provided byuser_opts
.Preview
Persistent seekbar now respects

user_opts.seekbar_cache_color