Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apply all hover effects by default, except for size, limit it #141

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

Samillion
Copy link
Owner

@Samillion Samillion commented Nov 1, 2024

Pinging: @Commander07 @Keith94

Note: This isn't mandotary, because I realize personal preference is a factor. That is why I decided not to merge but to first consult with you guys. (original PR maker and requester)

The hover effect size looks great on all elements, except for the following: (looks out of place)

  • Title (above seekbar)
  • Timestamps (left and right)
  • Chapter title (below seekbar)

The size hover effect will be stripped from them.

Other changes:

  • Tie elem_ass:append() to a nested condition, to ensure single action. (ie: in title, it was appending twice, hover and text)
  • Restore default value for hover_button_size to 115 instead of 110
  • Apply all effects in hovereffect
  • Change hovereffect_color to #CB7050, a slightly brighter match with the default seekbar color.
  • Remove redundant or contains(user_opts.hovereffect, "glow") condition, as it is applied/checked below it already.

Preview:

hover_effects_refactor.mp4

@Keith94
Copy link
Contributor

Keith94 commented Nov 1, 2024

Yup, the ones you excluded were bothering me the more I used the UI. It's a good change.

The volume handle size change is barely noticeable unless you really squint at it or set a high value like 135

@Samillion
Copy link
Owner Author

The volume handle size change is barely noticeable unless you really squint at it or set a high value like 135

😆 true

tenor

Glow is applied below it, no need to check for it there.
@Commander07
Copy link
Contributor

Looks much better with these changes.

@Samillion Samillion merged commit 2149ff5 into main Nov 1, 2024
@Samillion Samillion deleted the dev_size_hovereffect_refactor branch November 1, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants