Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update title formatting #137

Merged
merged 6 commits into from
Oct 31, 2024
Merged

refactor: update title formatting #137

merged 6 commits into from
Oct 31, 2024

Conversation

Keith94
Copy link
Contributor

@Keith94 Keith94 commented Oct 31, 2024

Makes it match osc.lua defaults.

@FreeTheTech101
Copy link
Contributor

Any opinions on defaulting to ${media-title/no-ext}? Assuming the file in question has a title set, there shouldn't be a difference, but in the event there isn't one and it falls back to the file name, omitting .mkv or .flac could keep things less cluttered. More so asking to see what everyones opinion is on it, not for any immediate changes.

@Keith94
Copy link
Contributor Author

Keith94 commented Oct 31, 2024

We used it before but it was removed due to a bug: #30

Sam provided a workaround for that though.

@Samillion
Copy link
Owner

Awesome! Thank you very much, I didn't even realize those notes weren't updated.

Changes to your PR:

  • fix: value for screenshot_flag. should be subtitles, not subs
  • fix: correctly close table row with | for the language option row
  • refactor: default title to ${media-title}. mpv relies on playlist positions because the stock OSC doesn't include native playlist button or tooltips. In ModernZ title would look cluttered with [2/5] title. Nevertheless, the user has the option to modify it to their liking.

@Samillion Samillion merged commit 0327896 into Samillion:main Oct 31, 2024
@Keith94
Copy link
Contributor Author

Keith94 commented Oct 31, 2024

Thanks for the fix 😃

@Keith94 Keith94 deleted the title-formatting branch October 31, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants