Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: button bar decluttering options (playlist & tooltips) #134

Merged
merged 6 commits into from
Oct 31, 2024
Merged

feat: button bar decluttering options (playlist & tooltips) #134

merged 6 commits into from
Oct 31, 2024

Conversation

Commander07
Copy link
Contributor

This PR adds button bar decluttering options for the playlist button and tooltips.

Changes

  • Added hide_empty_playlist_button which hides the playlist button when no playlist exists.
  • Added gray_empty_playlist_button which grays out the playlist button when no playlist exists. Which should solve Gray out playlist button if there's no playlist? #129.
  • Added tooltips_for_disabled_elements which disables tooltips for disabled/grayed out buttons. E.g. the sub track button when no subtitles are available.
  • Added tooltip_hints which toggles the clarification tooltips of the information, loop, ontop and screenshot buttons.

@Keith94
Copy link
Contributor

Keith94 commented Oct 30, 2024

This was much needed.. thanks @Commander07

@Samillion
Copy link
Owner

Samillion commented Oct 31, 2024

Brilliant, yet another great addition. Thank you so much.

I hate to ask, but there was a recent PR that renamed some of the osc styles, which introduced a conflict. Would you mind updating this, please? #135

At a glance I think it's just:

  • osc_styles.Tooltip => osc_styles.tooltip

@Samillion Samillion linked an issue Oct 31, 2024 that may be closed by this pull request
@FreeTheTech101
Copy link
Contributor

Appologizes on that, I thought I could sneak that in without causing any conflicts since there wasn't any use of styles from what I saw.

@Samillion
Copy link
Owner

Not at all, this was definitely my fault. I should have checked before merging. I would fix this myself, but right now I only have my phone.

Any inconvenience is on me, sorry for that.

@Commander07
Copy link
Contributor Author

Brilliant, yet another great addition. Thank you so much.

I hate to ask, but there was a recent PR that renamed some of the osc styles, which introduced a conflict. Would you mind updating this, please? #135

At a glance I think it's just:

* `osc_styles.Tooltip` => `osc_styles.tooltip`

Think it should be resolved now.

@Samillion
Copy link
Owner

Much appreciated, indeed it is resolved.

@Samillion Samillion merged commit 6c4497b into Samillion:main Oct 31, 2024
@Samillion Samillion changed the title Add button bar decluttering options (playlist & tooltips) feat: button bar decluttering options (playlist & tooltips) Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gray out playlist button if there's no playlist?
4 participants