Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window_fade_alpha not working when window_top_bar=yes and border=yes #228

Closed
2 tasks done
Keith94 opened this issue Nov 16, 2024 · 0 comments · Fixed by #232
Closed
2 tasks done

window_fade_alpha not working when window_top_bar=yes and border=yes #228

Keith94 opened this issue Nov 16, 2024 · 0 comments · Fixed by #232
Labels
bug Something isn't working

Comments

@Keith94
Copy link
Contributor

Keith94 commented Nov 16, 2024 •
edited
Loading

mpv Information

mpv 43d8966 Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on Nov 11 2024 22:24:18
libplacebo version: v7.349.0
FFmpeg version: b862792
FFmpeg library versions:
   libavcodec      61.19.100
   libavdevice     61.3.100
   libavfilter     10.4.100
   libavformat     61.7.100
   libavutil       59.39.100
   libswresample   5.3.100
   libswscale      8.3.100

Reproduction Steps

  1. open modernz.lua
  2. change window_top_bar = "auto", to window_top_bar = "yes",
  3. Add border=yes to mpv.conf
  4. Open a video file and hover OSC

Expected Behavior

window_fade_alpha works properly

Actual Behavior

there's no fade at all

image

Log File

No response

I carefully read all instructions and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information.
@Keith94 Keith94 added the bug Something isn't working label Nov 16, 2024
@Keith94 Keith94 changed the title window_fade_alpha not working when window_top_bar=yes window_fade_alpha not working when window_top_bar=yes and border=yes Nov 16, 2024
Xurdejl added a commit to Xurdejl/ModernZ that referenced this issue Nov 17, 2024
@Xurdejl
fix: resolve alpha bg issue with top_titlebar and border (Samillion#228)
40f662a
@Xurdejl Xurdejl mentioned this issue Nov 17, 2024
Closed
Xurdejl added a commit to Xurdejl/ModernZ that referenced this issue Nov 17, 2024
@Xurdejl
fix: window controls fade alpha and hide behaviour (Samillion#228, Sa…
bc5d8b7 
…million#229)

- Fix `window_fade_alpha` not working when `window_top_bar = yes` and `border = yes` (Samillion#228).
- Prevent OSC from hiding when hovering window controls with `window_top_bar = yes` and `border = yes` (Samillion#229).
@Xurdejl Xurdejl mentioned this issue Nov 17, 2024
Merged
Xurdejl added a commit to Xurdejl/ModernZ that referenced this issue Nov 17, 2024
@Xurdejl
fix: window controls fade alpha and hide behaviour (Samillion#228, Sa…
2bb6c72 
…million#229)

- Fix `window_fade_alpha` not working when `window_top_bar = yes` and `border = yes` (Samillion#228).
- Prevent OSC from hiding when hovering window controls with `window_top_bar = yes` and `border = yes` (Samillion#229).
Samillion added a commit that referenced this issue Nov 17, 2024
@Samillion
Merge pull request #232 from Xurdejl/fix/osc-window-controls-visibility
b0c7bb0 
fix: window controls fade alpha and hide behaviour (#228, #229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@Keith94