Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context not pass to completion.menu.auto_show #1290

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix: context not pass to completion.menu.auto_show #1290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eec4cea
fix: context not pass to completion.menu.auto_show
Methapon2001 Feb 21, 2025
41e004f
fix: pass items and context from open to auto_show
Saghen Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lua/blink/cmp/completion/windows/menu.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
--- @field open_loading fun(context: blink.cmp.Context)
--- @field open fun()
--- @field close fun()
--- @field should_auto_show fun(context: blink.cmp.Context, items: blink.cmp.CompletionItem[])
--- @field set_selected_item_idx fun(idx?: number)
--- @field update_position fun()
--- @field redraw_if_needed fun()
Expand Down Expand Up @@ -55,7 +56,7 @@ function menu.open_with_items(context, items)
if not menu.renderer then menu.renderer = require('blink.cmp.completion.windows.render').new(config.draw) end
menu.renderer:draw(context, menu.win:get_buf(), items)

if menu.should_auto_show() then
if menu.should_auto_show(context, items) then
menu.open()
menu.update_position()
end
Expand All @@ -81,7 +82,7 @@ function menu.open_loading(context)
},
})

if menu.should_auto_show() then
if menu.should_auto_show(context, {}) then
menu.open()
menu.update_position()
end
Expand Down Expand Up @@ -112,8 +113,8 @@ function menu.set_selected_item_idx(idx)
if menu.win:is_open() then menu.win:set_cursor({ idx or 1, 0 }) end
end

function menu.should_auto_show()
if type(menu.auto_show) == 'function' then return menu.auto_show() end
function menu.should_auto_show(context, items)
if type(menu.auto_show) == 'function' then return menu.auto_show(context, items) end
return menu.auto_show
end

Expand Down
Loading