Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): upgrade styled-components to v5 #7257

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

edleeks87
Copy link
Contributor

@edleeks87 edleeks87 commented Mar 12, 2025

Proposed behaviour

  • Upgrades styled-components dependency to v5 and @types/styled-components to latest

BREAKING CHANGE: styled-components is a peer dependency so consumers will need to install the new
version

  • upgrade typescript to v5.3.0
    In order to upgrade to latest TS we will need to upgrade eslint (v9) and its TS and parser plugins (v7 or greater). This will be done in a new ticket

Current behaviour

Checklist

  • Commits follow our style guide
  • Unit tests added or updated if required
  • Storybook added or updated if required
  • Typescript d.ts file added or updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Upgrades styled-components dependency to v5 and @types/styled-components to latest

BREAKING CHANGE: `styled-components` is a peer dependency so consumers will need to install the new
version
@edleeks87 edleeks87 self-assigned this Mar 12, 2025
@edleeks87 edleeks87 requested review from a team as code owners March 12, 2025 08:06
@edleeks87 edleeks87 added the Work in progress This is a WIP PR so may not be ready for review label Mar 12, 2025
TS upgraded to latest compatible version with current version of
eslint and its TS plugins used in Carbon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Work in progress This is a WIP PR so may not be ready for review
Development

Successfully merging this pull request may close these issues.

1 participant