Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tile): add important highlight variant #7256

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tomdavies73
Copy link
Contributor

@tomdavies73 tomdavies73 commented Mar 11, 2025

Proposed behaviour

Changes the highlight variants to better fit the Tile and align with DS designs (small, default and large roundness pictured)

Screenshot 2025-03-11 at 16 21 50

Adds the "important" variant which is available via the highlightVariant prop

Screenshot 2025-03-11 at 16 21 42

Current behaviour

Currently, there is no "important" variant available via the highlightVariant prop and the highlight variants available on Tile are not aligned with the design system.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

adds the important variant which is available by passing "important" to the `highlightVariant` prop
changes the appearance of the tile highlight to better fit within the tile
adds examples of a small roundness for each highlightVariant to improve documentation and provide a
better visual baseline via snapshots
@tomdavies73 tomdavies73 self-assigned this Mar 11, 2025
@tomdavies73 tomdavies73 requested review from a team as code owners March 11, 2025 16:24
@tomdavies73 tomdavies73 changed the title Fe 7105 feat: tile updates Mar 11, 2025
@edleeks87 edleeks87 changed the title feat: tile updates feat(tile): add important highlight variant Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant