Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-editor): fixes the formatting buttons when clicked to toggle without text selections #7255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damienrobson-sage
Copy link
Contributor

Proposed behaviour

The formatting is applied and any newly-added text is formatted in the correct way

Current behaviour

When using the command buttons to format text without any selections present, focus snaps to the text editor but no Bold/Italic formatting appears when text is entered.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Testing instructions

Using the default story, click either the Bold or Italic buttons and then type some text into the editor. The formatting should be applied. Click the button again and then continue typing; no further formatting should be applied.

@Parsium Parsium self-requested a review March 12, 2025 09:25
@damienrobson-sage damienrobson-sage force-pushed the FE-7106-text-editor-commands branch from 01db573 to af7f00a Compare March 13, 2025 07:52
@damienrobson-sage damienrobson-sage force-pushed the FE-7106-text-editor-commands branch from af7f00a to 7ebd7dd Compare March 13, 2025 09:15
@damienrobson-sage damienrobson-sage marked this pull request as ready for review March 13, 2025 10:26
@damienrobson-sage damienrobson-sage requested review from a team as code owners March 13, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants