Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secondary-button): split button additional secondary style #7250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(secondary-button): split button additional secondary style #7250

wants to merge 1 commit into from

Conversation

mihai-albu-sage
Copy link
Contributor

@mihai-albu-sage mihai-albu-sage commented Mar 10, 2025 •
edited
Loading

Proposed behaviour

A new variant has been added for the secondary SplitButton.

1

2

Current behaviour

Currently the secondary Split Button has only the default variant.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@mihai-albu-sage mihai-albu-sage self-assigned this Mar 10, 2025
@mihai-albu-sage mihai-albu-sage marked this pull request as ready for review March 12, 2025 07:37
@mihai-albu-sage mihai-albu-sage requested review from a team as code owners March 12, 2025 07:37
@mihai-albu-sage mihai-albu-sage marked this pull request as draft March 12, 2025 08:28
@mihai-albu-sage mihai-albu-sage marked this pull request as ready for review March 12, 2025 08:39
@mihai-albu-sage mihai-albu-sage marked this pull request as draft March 12, 2025 08:48
@mihai-albu-sage
fix(secondary-button): split button additional secondary style
1b21e2d 
added additional secondary style to the split button
@mihai-albu-sage mihai-albu-sage marked this pull request as ready for review March 12, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mihai-albu-sage mihai-albu-sage

Labels
Passed UX QA Pending QA Pending Review Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihai-albu-sage @harpalsingh