Bump rails from 5.2.4.5 to 6.0.3.6 #798
Conversation
.ebextensions/yarn.config
Outdated
| commands: | ||
| upgrade_nodejs_and_install_yarn: | ||
| command: | | ||
| /usr/bin/curl -sLO https://rpm.nodesource.com/pub_10.x/el/7/x86_64/nodesource-release-el7-1.noarch.rpm |
There was a problem hiding this comment.
Is this definitely idempotent? It’ll get run on every deploy.
There was a problem hiding this comment.
No. I added test to check if version 10.x of node is installed.
There was a problem hiding this comment.
Cool. You might also be able to do something with the yum support in ebextensions to make it a little simpler.
There was a problem hiding this comment.
| # available at https://guides.rubyonrails.org/i18n.html. | ||
|
|
||
| en: | ||
| hello: "Hello world" |
There was a problem hiding this comment.
I guess this won’t conflict with our existing translations?
There was a problem hiding this comment.
It seems that it doesn't.
[1] pry(main)> I18n.default_locale
=> :"en-US"
[2] pry(main)> I18n.t('bgeigie_imports.delete.delete_this_import')
=> "Delete this Import"
[3] pry(main)> I18n.locale = :ja
=> :ja
[4] pry(main)> I18n.t('bgeigie_imports.delete.delete_this_import')
=> "このインポートを削除する"
[5] pry(main)> I18n.t('hello')
=> "こんにちは"
[6] pry(main)> I18n.locale = :'en-US'
=> :"en-US"
[7] pry(main)> I18n.t('hello')
=> "Hello"
[8] pry(main)> I18n.locale = :en
=> :en
[9] pry(main)> I18n.t('hello')
=> "Hello world"
[10] pry(main)> I18n.t('bgeigie_imports.delete.delete_this_import')
=> "Delete this Import"
2.1 Configure the I18n Module
says in the following, but I don't understand what it means..
The i18n library takes a pragmatic approach to locale keys...
There was a problem hiding this comment.
Yeah I realized also our acceptance specs would fail if it was a problem. Looks good!
eitoball
force-pushed
the
bump-rails-to-6.0.3.6
branch
from
8449f62 to
0cadf23
Compare
eitoball
force-pushed
the
bump-rails-to-6.0.3.6
branch
2 times, most recently
from
56f25e9 to
761ef79
Compare
.ebextensions/yarn.config
Outdated
| nodesource: https://rpm.nodesource.com/pub_10.x/el/7/x86_64/nodesource-release-el7-1.noarch.rpm | ||
| container_commands: | ||
| 01_upgrade_nodejs: | ||
| command: yum -y install nodejs |
There was a problem hiding this comment.
did yum package not work? Says on https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/customize-containers-ec2.html rpm should get done first
.ebextensions/yarn.config
Outdated
| container_commands: | ||
| 01_upgrade_nodejs: | ||
| command: yum -y install nodejs | ||
| 02_install_yarn: | ||
| command: npm install --global yarn |
There was a problem hiding this comment.
| container_commands: | |
| 01_upgrade_nodejs: | |
| command: yum -y install nodejs | |
| 02_install_yarn: | |
| command: npm install --global yarn | |
| packages: | |
| rpm: | |
| nodesource: https://rpm.nodesource.com/pub_10.x/el/7/x86_64/nodesource-release-el7-1.noarch.rpm | |
| yum: | |
| nodejs: [] | |
| commands: | |
| install_yarn: | |
| command: npm install --global yarn |
Pretty sure this will work. Maybe not a big difference but seems cleaner.
eitoball
force-pushed
the
bump-rails-to-6.0.3.6
branch
from
761ef79 to
4fcced9
Compare
.ebextensions/yarn.config
Outdated
| nodesource: https://rpm.nodesource.com/pub_10.x/el/7/x86_64/nodesource-release-el7-1.noarch.rpm | ||
| yum: | ||
| nodejs: [] | ||
| container_commands: |
There was a problem hiding this comment.
I don't think this needs to be container commands, but probably fine.
commands happens before the new app bundle is downloaded, container_commands happens after.
eitoball
force-pushed
the
bump-rails-to-6.0.3.6
branch
from
4fcced9 to
3751b5d
Compare
Yep. I will create another PR to fix those warnings. |
Fixes #801