remove redundant begin

Safecast · May 16, 2020 · 2a685cf · 2a685cf
1 parent 8cbbcdd
commit 2a685cf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/app/safecast/tasks/device_story/update_metadata.rb b/app/safecast/tasks/device_story/update_metadata.rb
@@ -11,11 +11,9 @@ def call
 
       def call
         each_metadata(parse(fetch(devices_uri))) do |device_urn, metadata|
-          begin
-            find_or_update_device(device_urn, metadata)
-          rescue ActiveRecord::RecordInvalid
-            warn "Could not update device metadata for #{device_urn}."
-          end
+          find_or_update_device(device_urn, metadata)
+        rescue ActiveRecord::RecordInvalid
+          warn "Could not update device metadata for #{device_urn}."
         end
       end
 

diff --git a/bin/yarn b/bin/yarn
@@ -3,11 +3,9 @@
 
 APP_ROOT = File.expand_path('..', __dir__)
 Dir.chdir(APP_ROOT) do
-  begin
-    exec 'yarnpkg', *ARGV
-  rescue Errno::ENOENT
-    warn 'Yarn executable was not detected in the system.'
-    warn 'Download Yarn at https://yarnpkg.com/en/docs/install'
-    exit 1
-  end
+  exec 'yarnpkg', *ARGV
+rescue Errno::ENOENT
+  warn 'Yarn executable was not detected in the system.'
+  warn 'Download Yarn at https://yarnpkg.com/en/docs/install'
+  exit 1
 end