feat(packages/sui-bundler): add proper context to bundler #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresz1
requested review from
sui-bot,
kikoruiz,
nucliweb,
ferransimon and
andresin87
as code owners
hpintos
approved these changes
Apr 23, 2025
kikoruiz
reviewed
Apr 23, 2025
| @@ -39,7 +39,7 @@ const webpackConfig = { | |||
| name: 'client', | |||
| mode: 'production', | |||
| target, | |||
| context: path.resolve(CWD, 'src'), | |||
| context: path.resolve(process.cwd(), 'src'), | |||
There was a problem hiding this comment.
Here you are changing the same value I guess
kikoruiz
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds proper context to sui bundler in case that the app is inside
appfolder for example, and not inside the rootRelated Issue
Example