-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D8CORE-7726: adding space for touch targets on Events node taxonomy terms. #368
Conversation
8759994
to
b4094b5
Compare
@@ -86,10 +86,17 @@ | |||
} | |||
|
|||
.su-event-type-bottom { | |||
&.su-event-type { | |||
div { | |||
padding: 0.1em 0.3em 0.1em 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be on the link, not the div. the div has no affect on touch target. A touch target is a button, link, input, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I removed it from the div
and added to the a
. I added it to the top term as well and paid attention to the commas not moving if multiples at the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the change in the PR, please make sure you push the commits
b4094b5
to
a437179
Compare
a437179
to
74ce728
Compare
74ce728
to
b305ad6
Compare
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Urgency
Review Tasks
Setup tasks and/or behavior to test
drush cr ; drush ci
Site Configuration Sync
Front End Validation
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People
- D8CORE-7726
Resources