Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7726: adding space for touch targets on Events node taxonomy terms. #368

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Feb 11, 2025

READY FOR REVIEW

Summary

  • Added padding to the taxonomy link at the bottom of the event node page
  • Increased the line-height

Review By (Date)

  • Next release

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Create am event
  4. add multiple topics to the event
  5. Navigate to event node
  6. Verify padding and line-height are increased.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-7726

Resources

@jenbreese jenbreese requested a review from pookmish February 12, 2025 17:25
@jenbreese jenbreese changed the title D8CORE-7726: adding space for touch targets D8CORE-7726: adding space for touch targets on Events node taxonomy terms. Feb 12, 2025
@pookmish pookmish force-pushed the D8CORE-7726--topics branch from 8759994 to b4094b5 Compare February 12, 2025 18:09
@@ -86,10 +86,17 @@
}

.su-event-type-bottom {
&.su-event-type {
div {
padding: 0.1em 0.3em 0.1em 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be on the link, not the div. the div has no affect on touch target. A touch target is a button, link, input, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I removed it from the div and added to the a. I added it to the top term as well and paid attention to the commas not moving if multiples at the top.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the change in the PR, please make sure you push the commits

@pookmish pookmish force-pushed the D8CORE-7726--topics branch from 74ce728 to b305ad6 Compare February 12, 2025 19:10
@pookmish pookmish merged commit a4ec274 into 9.x Feb 12, 2025
4 of 8 checks passed
@pookmish pookmish deleted the D8CORE-7726--topics branch February 12, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants