Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7662: added new layout to the config #876

Open
wants to merge 1 commit into
base: 11.x
Choose a base branch
from

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Feb 28, 2025

READY FOR REVIEW

Summary

  • A new layout for the filtered paragraph.
  • This was to be a single col and then the filtered paragraph does the layout part.

Review By (Date)

  • For next release

Criticality

  • Important

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add in the config change from the linked PR from below.
  3. Rebuild Cache and import config drush cr ; drush ci
  4. Navigate to a basic page and add a section called 1 Column with filters
  5. Verify no errors and that the class is there class="layout layout--layout-paragraphs-one-column-filters"
  6. Verify that you can add paragraphs to the section.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? YES

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-7662
- Config PR
- Layout PR

Resources

Copy link
Contributor

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to wait until after the next release and when we are ready with the paragraph type and all restrictions prevent other paragraph types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants