Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7661: Filtered List Paragraph with sample view #848

Open
wants to merge 6 commits into
base: 11.x
Choose a base branch
from

Conversation

buttonwillowsix
Copy link
Contributor

@buttonwillowsix buttonwillowsix commented Jan 17, 2025

NOT READY FOR REVIEW

  • Need to decide where to allow this to be selected (currently in 1 column, but probably should be in full-width list)

Summary

  • Proof of concept for Filtered Lists Paragraph
  • Includes courses views (unstyled) with multiple filters
  • Needs styling for top filters (ticket to be made)

Review By (Date)

-5.5.0 Code Freeze

Criticality

-Important for VPUE work

Urgency

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Import some courses using the course importer
  3. Change the 1 column layout to allow this paragraph type to be added to a display
  4. Create a basic page or use an existing basic page
  5. Create a 1 column section
  6. Throw a Filtered List paragraph in the 1-column section
  7. Try both displays

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • [ YES] Are the naming conventions following our standards?
  • [N/A ] Does the code have sufficient inline comments?
  • [ NO] Is there anything in this code that would be hidden or hard to discover through the UI?
  • [ NO] Are there any code smells?
  • [ NO] Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • [ NO] Is there anything included in this PR that is not related to the problem it is trying to solve?
  • [ UNKNOWN] Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • Opportunities Content Type

Resources

@github-actions github-actions bot added the patch label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant