Added Array type to navigateTo prop type check #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated readme.md; Added example usage to Vue play file
|
Hey @rico-ocepek, thanks for this! I'll test and merge in this afternoon 🚀 |
|
Hi @quinnlangille, sorry to bother you again - do we have any progress here? Would love to integrate this feature in a client project without anyone asking why there is an error message 😅 |
ashleysimpson
approved these changes
Feb 19, 2019
|
Hey @rico-ocepek sorry for the delay! I've merged and published as an alpha tag since you needed it quickly - you can find it with |
|
No worries @quinnlangille, thank you for your help and your great work here! 👍🏻 |
quinnlangille
pushed a commit
that referenced
this pull request
Mar 18, 2019
Updated readme.md; Added example usage to Vue play file
quinnlangille
pushed a commit
that referenced
this pull request
Mar 21, 2019
Updated readme.md; Added example usage to Vue play file
quinnlangille
pushed a commit
that referenced
this pull request
Mar 21, 2019
Updated readme.md; Added example usage to Vue play file
quinnlangille
pushed a commit
that referenced
this pull request
Mar 21, 2019
Updated readme.md; Added example usage to Vue play file
quinnlangille
pushed a commit
that referenced
this pull request
Mar 21, 2019
Updated readme.md; Added example usage to Vue play file
quinnlangille
pushed a commit
that referenced
this pull request
Mar 21, 2019
Updated readme.md; Added example usage to Vue play file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the property type of the carousel's navigateTo property from Number only to [Number, Array].
Also updated readme.md to describe the new behaviour.
Updated the "NavigateTo slides" Vue play example to include an example of the new API usage.
Motivation and Context
As the pending fix from https://github.com/SSENSE/vue-carousel/issues/257 should finally be done I decided to help you out a bit.
How Has This Been Tested?
As the feature was already implemented and only the property type was wrong further tests should not be required.
However I did test both cases of the navigateTo property (animated and non animated) and couldn't spot any errors.
As I said I also included an example in the Vue play file for testing purposes.
Types of changes
Checklist: