Slides flushed right instead of left with scrollPerPage #323
Comments
AdminXVII
added a commit
to AdminXVII/vue-carousel
that referenced
this issue
Nov 24, 2018
…SENSE#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix SSENSE#323
7 tasks
quinnlangille
pushed a commit
that referenced
this issue
Dec 7, 2018
…323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency
quinnlangille
pushed a commit
that referenced
this issue
Dec 18, 2018
* fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay
quinnlangille
pushed a commit
that referenced
this issue
Dec 19, 2018
* feat(carousel): Count slides by custom tag name * fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * Rebuild * Use Vue Test Utils, rebuild * Discard change to package version
quinnlangille
pushed a commit
that referenced
this issue
Dec 19, 2018
* fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay
quinnlangille
pushed a commit
that referenced
this issue
Dec 19, 2018
* feat(carousel): Count slides by custom tag name * fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * Rebuild * Use Vue Test Utils, rebuild * Discard change to package version
VojtechKlos
pushed a commit
to Symphony9/vue-carousel
that referenced
this issue
Dec 20, 2018
* fix(carousel): flush the slides left when they don't fill the width (SSENSE#323) * fix(carousel): Flush the slides left when they don't fill the width (SSENSE#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix SSENSE#323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay
quinnlangille
pushed a commit
that referenced
this issue
Dec 20, 2018
* Clean up to prepare for test script refactor (#330) * fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools * style(eslint): commit eslint fixes (#336) * feat: add watcher to Autoplay Prop (#344) * fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay * feat(pagination) added an option to add custom title in pagination buttons * updated test snapshots * fixed wrong conflict resolution of carousel.vue
quinnlangille
pushed a commit
that referenced
this issue
Dec 27, 2018
* fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay
quinnlangille
pushed a commit
that referenced
this issue
Dec 27, 2018
* feat(carousel): Count slides by custom tag name * fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * Rebuild * Use Vue Test Utils, rebuild * Discard change to package version
quinnlangille
pushed a commit
that referenced
this issue
Dec 27, 2018
* Clean up to prepare for test script refactor (#330) * fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools * style(eslint): commit eslint fixes (#336) * feat: add watcher to Autoplay Prop (#344) * fix(carousel): flush the slides left when they don't fill the width (#323) * fix(carousel): Flush the slides left when they don't fill the width (#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix #323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay * feat(pagination) added an option to add custom title in pagination buttons * updated test snapshots * fixed wrong conflict resolution of carousel.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Current Behavior
When there are too few slides to fill the row, with scrollPerPage, the slides are flushed right instead of left.
Input Code and steps to reproduce
https://jsfiddle.net/AdminXVII/eywraw8t/473381/
Expected behavior/code
In LTR at least, slides should flush left.
Possible Solution
Problem seems with maxOffset, which is not constrained to a minimum value of 0.
The text was updated successfully, but these errors were encountered: