fix(styles): redesign line/link Tiles in both static and edit mode #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The focus outline radius doesn't have the same radius as the Tile |
Active state: there should be 1 outline. |
Screen.Recording.2024-10-03.at.11.51.54.AM.movthere's a "jump" on hover. Probably somewhere you set/remove a border that causes change of element height. |
Please fix the lint errors
|
InnaAtanasova
requested changes
Oct 3, 2024
InnaAtanasova
changed the title
alexhristov14
force-pushed
the
feat/line-tiles
branch
from
bd62a90 to
27ac9a6
Compare
InnaAtanasova
requested changes
Oct 9, 2024
alexhristov14
changed the title
alexhristov14
force-pushed
the
feat/line-tiles
branch
from
27ac9a6 to
220dc91
Compare
alexhristov14
changed the title
|
@InnaAtanasova can you check? |
alexhristov14
force-pushed
the
feat/line-tiles
branch
from
220dc91 to
4f8b1c3
Compare
alexhristov14
force-pushed
the
feat/line-tiles
branch
from
4f8b1c3 to
7803de5
Compare
InnaAtanasova
modified the milestones:
Sprint 141 - December 2024,
Sprint 142 - January 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
related to SAP/fundamental-ngx#11490
Description
Design changes to the generic line tiles according to the specs
Screenshots
Before:
After: