Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform, cdk): Drag & drop auto detect mode #9626

Merged
merged 3 commits into from
Apr 5, 2023
Merged

feat(platform, cdk): Drag & drop auto detect mode #9626

merged 3 commits into from
Apr 5, 2023

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Apr 3, 2023

Related Issue(s)

closes #9421

Description

  • Refactored dnd directive to support 'auto' option of dropping the item. Depending on the coordinates of the dropped item it will switch between replace and after modes.
  • replaced mode was deprecated in favour of dropMode;
  • added documentation section in cdk to reflect dnd functionality;
  • Applied new dnd feature to platform table;
  • splitted platform table into few smaller pages because locally e2e always fails with hanged chrome.

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@N1XUS N1XUS added enhancement New feature or request documentation There is an issue with documentation platform platform e2e table labels Apr 3, 2023
@N1XUS N1XUS added this to the Sprint 110 milestone Apr 3, 2023
@N1XUS N1XUS requested a review from a team April 3, 2023 14:30
@N1XUS N1XUS requested a review from mikerodonnell89 as a code owner April 3, 2023 14:30
@N1XUS N1XUS self-assigned this Apr 3, 2023
@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit a5ba24a
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/642d238e5992a00008248c7a
😎 Deploy Preview https://deploy-preview-9626--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Visit the preview URL for this PR (updated for commit a5ba24a):

https://fundamental-ngx-gh--pr9626-dnd-83869xp7.web.app

(expires Sat, 08 Apr 2023 07:45:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@N1XUS N1XUS changed the title Dnd Drag & drop auto detect mode Apr 3, 2023
@InnaAtanasova
Copy link
Contributor

hey Denis, you need to name your PR properly

@mikerodonnell89 mikerodonnell89 changed the title Drag & drop auto detect mode feat(platform, cdk): Drag & drop auto detect mode Apr 4, 2023
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent work 👍

@N1XUS N1XUS merged commit e4b5c6c into main Apr 5, 2023
@N1XUS N1XUS deleted the dnd branch April 5, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation There is an issue with documentation e2e enhancement New feature or request platform platform table
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform tree table drag and drop improvements
3 participants