Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new content density mechanism #9596

Merged
merged 10 commits into from
Apr 5, 2023
Merged

feat: new content density mechanism #9596

merged 10 commits into from
Apr 5, 2023

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Mar 28, 2023

Description

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@N1XUS N1XUS added documentation There is an issue with documentation code refactoring platform platform core Core library specific issues labels Mar 28, 2023
@N1XUS N1XUS added this to the Sprint 109 milestone Mar 28, 2023
@N1XUS N1XUS requested a review from a team March 28, 2023 08:48
@N1XUS N1XUS self-assigned this Mar 28, 2023
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit fcc3aa2
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/642c355dd68c1d000865abf6
😎 Deploy Preview https://deploy-preview-9596--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 28, 2023

Visit the preview URL for this PR (updated for commit fcc3aa2):

https://fundamental-ngx-gh--pr9596-feat-new-content-den-uw61g162.web.app

(expires Fri, 07 Apr 2023 14:45:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@g-cheishvili g-cheishvili changed the title feat: new content density methanizm feat: new content density mechanism Mar 28, 2023
Copy link
Contributor

@g-cheishvili g-cheishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification, now basically none of the HTML usages are needed and you can just use it

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core menu items are not responding to density changes. Also same with combobox, multicombobox, multiinput, i suspect all the same reasons:

Screen.Recording.2023-03-28.at.2.56.30.PM.mov

@mikerodonnell89
Copy link
Member

Datepicker items still showing in cozy when everything else is compact - could be just a popover contents thing in general?
Screenshot 2023-03-28 at 3 23 03 PM

@mikerodonnell89
Copy link
Member

mikerodonnell89 commented Mar 28, 2023

Specs state that the feed input button should always be used in cozy mode
Screenshot 2023-03-28 at 3 27 28 PM

@mikerodonnell89
Copy link
Member

mikerodonnell89 commented Mar 28, 2023

Input group and form message focus outlines are behaving odd on this PR but not on the current netlify build for the latest main: https://fundamental-ngx.netlify.app/#/platform/input-group.

From the platform input group docs, in this first screenshot, after clicking submit, the whole docs page gets focused
Screenshot 2023-03-28 at 3 31 41 PM

From the platform input group docs, here we see the whole input gets a focus outline
Screenshot 2023-03-28 at 3 31 32 PM

This is from core input group:
Screenshot 2023-03-28 at 3 34 09 PM

@N1XUS N1XUS force-pushed the feat/new-content-density branch 3 times, most recently from e8e6d94 to 9fce33e Compare March 29, 2023 10:23
@N1XUS N1XUS requested a review from mikerodonnell89 March 29, 2023 11:17
@N1XUS
Copy link
Contributor Author

N1XUS commented Mar 29, 2023

@mikerodonnell89 Thank you for your review! Please re-check, all items has been addressed.

@mikerodonnell89
Copy link
Member

Not caused by this PR, but, possibly related and fixable here? #9607

image

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few focus outline issues coming from a recent fundamental-styles RC release so I think we need to hold off merging this (or updating fundamental-styles in general) until those issues can be fixed

@N1XUS
Copy link
Contributor Author

N1XUS commented Mar 30, 2023

Not caused by this PR, but, possibly related and fixable here? #9607

image

Yes, it is reproducible in main too, so it is not comming from this PR

@InnaAtanasova InnaAtanasova modified the milestones: Sprint 109, Sprint 110 Mar 31, 2023
@N1XUS N1XUS force-pushed the feat/new-content-density branch from 9fce33e to 1e22e1a Compare April 4, 2023 08:24
@N1XUS N1XUS force-pushed the feat/new-content-density branch from b14e45f to fcc3aa2 Compare April 4, 2023 14:34
@N1XUS N1XUS merged commit 34c15ba into main Apr 5, 2023
@N1XUS N1XUS deleted the feat/new-content-density branch April 5, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code refactoring core Core library specific issues documentation There is an issue with documentation platform platform
Projects
None yet
4 participants