-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new content density mechanism #9596
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Visit the preview URL for this PR (updated for commit fcc3aa2): https://fundamental-ngx-gh--pr9596-feat-new-content-den-uw61g162.web.app (expires Fri, 07 Apr 2023 14:45:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simplification, now basically none of the HTML usages are needed and you can just use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core menu items are not responding to density changes. Also same with combobox, multicombobox, multiinput, i suspect all the same reasons:
Screen.Recording.2023-03-28.at.2.56.30.PM.mov
Input group and form message focus outlines are behaving odd on this PR but not on the current netlify build for the latest main: https://fundamental-ngx.netlify.app/#/platform/input-group. From the platform input group docs, in this first screenshot, after clicking submit, the whole docs page gets focused From the platform input group docs, here we see the whole input gets a focus outline |
e8e6d94
to
9fce33e
Compare
@mikerodonnell89 Thank you for your review! Please re-check, all items has been addressed. |
Not caused by this PR, but, possibly related and fixable here? #9607 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few focus outline issues coming from a recent fundamental-styles RC release so I think we need to hold off merging this (or updating fundamental-styles in general) until those issues can be fixed
Yes, it is reproducible in main too, so it is not comming from this PR |
9fce33e
to
1e22e1a
Compare
b14e45f
to
fcc3aa2
Compare
Description
Please check whether the PR fulfills the following requirements
During Implementation
PR Quality
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
README.md