Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: platform table keyboard dnd #9420

Merged
merged 10 commits into from
Mar 7, 2023
Merged

Conversation

mikerodonnell89
Copy link
Member

fixes #9137

Focus a cell, press and hold alt/option key and use the up/down arrow keys to move it. Currently has the same behavior as mouse drag and drop

@mikerodonnell89 mikerodonnell89 added the accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support label Feb 20, 2023
@mikerodonnell89 mikerodonnell89 added this to the Sprint 106 milestone Feb 20, 2023
@mikerodonnell89 mikerodonnell89 requested a review from a team February 20, 2023 20:00
@mikerodonnell89 mikerodonnell89 self-assigned this Feb 20, 2023
@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit a5d56bd
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6406653e5c2c550008ca392c
😎 Deploy Preview https://deploy-preview-9420--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 20, 2023

Visit the preview URL for this PR (updated for commit a5d56bd):

https://fundamental-ngx-gh--pr9420-fix-platform-table-k-5yksfkh6.web.app

(expires Thu, 09 Mar 2023 22:24:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Copy link
Contributor

@platon-rov platon-rov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior doesn't look predictable, some when moving up/down doesn't take effect, here is a short video

Screen.Recording.2023-02-23.at.15.54.54.mov

@mikerodonnell89
Copy link
Member Author

Behavior doesn't look predictable, some when moving up/down doesn't take effect, here is a short video

This is simply working the same way as if you were to click and drag the item one row up or down, so I think this can be considered the intended behavior. We have been talking about needing various platform table dnd improvements, I've created an issue here #9421

@InnaAtanasova InnaAtanasova modified the milestones: Sprint 106, Sprint 107 Feb 24, 2023
Copy link
Contributor

@g-cheishvili g-cheishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After one successful drag with keyboard, focus was lost and it is kinda hard to guess where next action will go 😀

@mikerodonnell89 mikerodonnell89 requested review from platon-rov and removed request for platon-rov March 2, 2023 17:12
@g-cheishvili
Copy link
Contributor

g-cheishvili commented Mar 6, 2023

After you group something with alt/option+arrow down you can not ungroup it. Focus is fixed though.
The same thing happens with mouse interaction, if you drag one item into another, there is no way to ungroup it, dragging child item above parent does not do anything.

Expectation probably is that after arrow down action, arrow up will set child on a level of a parent

@mikerodonnell89
Copy link
Member Author

After you group something with alt/option+arrow down you can not ungroup it. Focus is fixed though. The same thing happens with mouse interaction, if you drag one item into another, there is no way to ungroup it, dragging child item above parent does not do anything.

Expectation probably is that after arrow down action, arrow up will set child on a level of a parent

Yes, we'll worry about that here: #9421

@mikerodonnell89 mikerodonnell89 merged commit 5142679 into main Mar 7, 2023
@mikerodonnell89 mikerodonnell89 deleted the fix/platform-table-keyboard-dnd branch March 7, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility][Sourcing]: Drag drop table rows not possible using keyboard
4 participants