-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: platform table keyboard dnd #9420
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Visit the preview URL for this PR (updated for commit a5d56bd): https://fundamental-ngx-gh--pr9420-fix-platform-table-k-5yksfkh6.web.app (expires Thu, 09 Mar 2023 22:24:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behavior doesn't look predictable, some when moving up/down doesn't take effect, here is a short video
Screen.Recording.2023-02-23.at.15.54.54.mov
This is simply working the same way as if you were to click and drag the item one row up or down, so I think this can be considered the intended behavior. We have been talking about needing various platform table dnd improvements, I've created an issue here #9421 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After one successful drag with keyboard, focus was lost and it is kinda hard to guess where next action will go 😀
After you group something with Expectation probably is that after arrow down action, arrow up will set child on a level of a parent |
Yes, we'll worry about that here: #9421 |
fixes #9137
Focus a cell, press and hold alt/option key and use the up/down arrow keys to move it. Currently has the same behavior as mouse drag and drop