fix(core): fixed card layout flickering issue #8476
Merged
+23
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platon-rov
added
enhancement
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
g-cheishvili
approved these changes
Jul 29, 2022
|
Visit the preview URL for this PR (updated for commit da13877): https://fundamental-ngx-gh--pr8476-pr-fix-fcl-flickerin-hw019q2e.web.app (expires Fri, 05 Aug 2022 04:22:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
mikerodonnell89
approved these changes
Jul 29, 2022
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
InnaAtanasova
approved these changes
Aug 1, 2022
…y to fix unit tests BREAKING CHANGES: * if you rely on dimensions in your unit tests now you have to call component's `updateLayout()` method to organize cards into the columns.
platon-rov
force-pushed
the
pr/fix/fcl-flickering
branch
from
f625c7d to
da13877
Compare
platon-rov
added a commit
that referenced
this pull request
Aug 2, 2022
…)" This reverts commit 54e89a9.
platon-rov
added a commit
that referenced
this pull request
Aug 2, 2022
This reverts commit 54e89a9.
droshev
pushed a commit
that referenced
this pull request
Aug 2, 2022
platon-rov
added a commit
that referenced
this pull request
Aug 2, 2022
BREAKING CHANGES: * If you rely on dimensions in your unit tests now you have to call component's `updateLayout()` method to organize cards into the columns.
platon-rov
added a commit
that referenced
this pull request
Aug 2, 2022
BREAKING CHANGE: * If you rely on dimensions in your unit tests now you have to call component's `updateLayout()` method to organize cards into the columns.
1 task
platon-rov
added a commit
that referenced
this pull request
Aug 5, 2022
BREAKING CHANGE: * If you rely on dimensions in your unit tests now you have to call component's `updateLayout()` method to organize cards into the columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Refers to Kafka.
Description
Screenshots
Before:
Notice: scrollbars present for a moment.
Screen.Recording.2022-07-29.at.13.17.56.mov
After:
Screen.Recording.2022-07-29.at.13.10.35.mov
Please check whether the PR fulfills the following requirements
PR Quality
Notice: Relates only to unit testing.