Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Core) remove card-footer component #5158

Merged
merged 3 commits into from
May 3, 2021
Merged

fix: (Core) remove card-footer component #5158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef7760c
fix:remove card-footer component
DeepakSap14 Apr 19, 2021
4df5d3d
removed card footer from api-file
DeepakSap14 Apr 19, 2021
6f13a66
fix travis
DeepakSap14 Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/docs/src/app/core/api-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ export const API_FILES = {
'CardSubtitleDirective',
'CardSecondSubtitleDirective',
'CardContentComponent',
'CardFooterComponent',
'CardLoaderComponent',
'CardKpiHeaderComponent',
'CardKpiValueDirective',
Expand Down
2 changes: 2 additions & 0 deletions apps/docs/src/app/core/component-docs/card/card-docs.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { RouterModule, Routes } from '@angular/router';

import {
CardModule,
BarModule,
ButtonModule,
BusyIndicatorModule,
ObjectStatusModule,
Expand Down Expand Up @@ -51,6 +52,7 @@ const routes: Routes = [
RouterModule.forChild(routes),
SharedDocumentationPageModule,
CardModule,
BarModule,
ButtonModule,
BusyIndicatorModule,
ObjectStatusModule,
Expand Down
14 changes: 8 additions & 6 deletions apps/docs/src/app/core/component-docs/card/examples/card-footer-example.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ <h2 fd-card-title>Card Title</h2>
</span>
</li>
</ul>
<div fd-bar barDesign="footer" [cozy]="false">
<div fd-bar-right>
<fd-toolbar size="compact" fdType="transparent" [clearBorder]="true">
<button fd-toolbar-item fd-button fdType="positive" [compact]="true">Approve</button>
<button fd-toolbar-item fd-button fdType="negative" [compact]="true">Reject</button>
</fd-toolbar>
</div>
</div>
</fd-card-content>
<fd-card-footer>
<fd-toolbar size="compact" fdType="transparent" [clearBorder]="true">
<button fd-toolbar-item fd-button fdType="positive" [compact]="true">Approve</button>
<button fd-toolbar-item fd-button fdType="negative" [compact]="true">Reject</button>
</fd-toolbar>
</fd-card-footer>
</fd-card>
12 changes: 7 additions & 5 deletions .../core/component-docs/card/examples/quick-view-card/card-quick-view-example.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,13 @@ <h2 fd-card-title>Contact Card</h2>
</fd-quick-view-group-item>
</fd-quick-view-group>
</fd-quick-view>
<div fd-bar barDesign="footer" [cozy]="false">
<div fd-bar-right>
<fd-toolbar size="compact" fdType="transparent" [clearBorder]="true">
<button fd-toolbar-item fd-button [compact]="true">Assign to Project</button>
</fd-toolbar>
</div>
</div>
</fd-card-content>
<fd-card-footer>
<fd-toolbar size="compact" fdType="transparent" [clearBorder]="true">
<button fd-toolbar-item fd-button [compact]="true">Assign to Project</button>
</fd-toolbar>
</fd-card-footer>
</fd-card>
</div>
2 changes: 1 addition & 1 deletion e2e/wdio/core/pages/card.po.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class CardPo extends CoreBaseComponentPo {
// footer examples
ftCardHeader = 'fd-card-footer-example fd-card-header';
ftCardListItems = 'fd-card-footer-example li';
ftFooter = 'fd-card-footer-example fd-card-footer';
ftFooter = 'fd-card-footer-example .fd-bar .fd-bar__right';
ftButtons = 'fd-card-footer-example fd-toolbar button';
// analytical card examples
kpiCardHeader = 'fd-card-kpi-example fd-card-header';
Expand Down
31 changes: 0 additions & 31 deletions libs/core/src/lib/card/card-footer.component.spec.ts
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions libs/core/src/lib/card/card-footer.component.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions libs/core/src/lib/card/card.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { CardSubtitleDirective } from './card-subtitle.directive';
import { CardSecondSubtitleDirective } from './card-second-subtitle.directive';
import { CardCounterDirective } from './card-counter.directive';
import { CardContentComponent } from './card-content.component';
import { CardFooterComponent } from './card-footer.component';
import { CardLoaderComponent } from './card-loader.component';

import { CardKpiHeaderComponent } from './kpi/card-kpi-header.component';
Expand All @@ -27,7 +26,6 @@ const components = [
CardComponent,
CardHeaderComponent,
CardContentComponent,
CardFooterComponent,
CardTitleDirective,
CardSubtitleDirective,
CardSecondSubtitleDirective,
Expand Down
1 change: 0 additions & 1 deletion libs/core/src/lib/card/public_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export { CardTitleDirective } from './card-title.directive';
export { CardSubtitleDirective } from './card-subtitle.directive';
export { CardSecondSubtitleDirective } from './card-second-subtitle.directive';
export { CardContentComponent } from './card-content.component';
export { CardFooterComponent } from './card-footer.component';
export { CardLoaderComponent } from './card-loader.component';

export { CardKpiHeaderComponent } from './kpi/card-kpi-header.component';
Expand Down