Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test nx with update on on-pull-request.yml #13038

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Feb 13, 2025

Related Issue(s)

closes

Description

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@droshev droshev changed the title test: test nx with update on on-pull-request.yml [WIP]test: test nx with update on on-pull-request.yml Feb 13, 2025
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 0a7f6de
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/67ae237ea114cd00089176ea
😎 Deploy Preview https://deploy-preview-13038--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 91effe7
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/67ae23bc0553ae0008e12941
😎 Deploy Preview https://deploy-preview-13038--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@droshev droshev changed the title [WIP]test: test nx with update on on-pull-request.yml test: test nx with update on on-pull-request.yml Feb 13, 2025
@droshev droshev merged commit dc14624 into main Feb 13, 2025
16 of 17 checks passed
@droshev droshev deleted the droshev-patch-1 branch February 13, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant